Arm backend: Use bucket approach in fuse_equal_placeholder_pass #13271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified to catch same dupes as before in lstm and mv2. Instead of comparing all placeholders to each other, compute a hash use as key in dictionary. Equal placeholder -> equal key. If an entry in the dictionary has multiple values, we have duplicates. This is a ~O(N) algorithm compared to earlier O(N^2). This can be seen by measuring the speedup for lstm vs. mv2 lstm: 120 placeholders (116 dupes) 0.4s -> 0.3s mv2: 318 placeholders (98 dupes) ~15s -> 0.5s Signed-off-by: Erik Lundell <[email protected]> Change-Id: I7e2e614402488e7f9437cd7db5212c928176ba32
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13271
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Cancelled Jobs, 1 Unrelated FailureAs of commit cdadc5e with merge base 72580d2 ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
meta-cla
bot
added
the
CLA Signed
|
Test failures unrelated. |
Sebastian-Larsson
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified to catch same dupes as before in lstm and mv2.
Instead of comparing all placeholders to each other, compute a hash use as key in dictionary. Equal placeholder -> equal key. If an entry in the dictionary has multiple values, we have duplicates.
This is a ~O(N) algorithm compared to earlier O(N^2). This can be seen by measuring the speedup for lstm vs. mv2
lstm: 120 placeholders (116 dupes) 0.4s -> 0.3s
mv2: 318 placeholders (98 dupes) ~15s -> 0.5s
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218